Skip to content

HHH-19702 ConnectionProvider rename #10729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Aug 10, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19702

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 10, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@gavinking gavinking force-pushed the connection-providers branch from acaf88e to 52b3439 Compare August 10, 2025 08:23
@gavinking gavinking marked this pull request as ready for review August 10, 2025 08:43
@gavinking gavinking force-pushed the connection-providers branch from 52b3439 to 749c05e Compare August 10, 2025 09:04
@gavinking gavinking changed the title fix "weird" unwrap logic in the ConnectionProviders HHH-19702 ConnectionProvider naming and unwrapping Aug 10, 2025
@gavinking
Copy link
Member Author

@DavideD Note that HHH-19702 trivially impacts Hibernate Reactive

serviceRegistry.requireService( ClassLoaderService.class )
.classForName( driverClassName );
try {
return driverClass.newInstance();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Class.newInstance
should be avoided because it has been deprecated.
}
else {
try {
return (Driver) Class.forName( driverClassName ).newInstance();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Class.newInstance
should be avoided because it has been deprecated.
serviceRegistry.requireService( ClassLoaderService.class )
.classForName( connectionCreatorFactoryClassName );
try {
return factoryClass.newInstance();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Class.newInstance
should be avoided because it has been deprecated.
}
else {
try {
return (ConnectionCreatorFactory) Class.forName( connectionCreatorFactoryClassName ).newInstance();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Class.newInstance
should be avoided because it has been deprecated.
if ( state != null ) {
state.stop();
}
super.finalize();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Object.finalize
should be avoided because it has been deprecated.
@gavinking gavinking force-pushed the connection-providers branch from 749c05e to 1431d8e Compare August 10, 2025 10:00
@gavinking gavinking changed the title HHH-19702 ConnectionProvider naming and unwrapping HHH-19702 ConnectionProvider rename Aug 10, 2025
@gavinking gavinking requested a review from sebersole August 10, 2025 10:09
@gavinking
Copy link
Member Author

@sebersole WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant